Skip to content

fix(zero_repeat_side_effects): don't suggest unsuggestable types #15815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(zero_repeat_side_effects): don't suggest unsuggestable types #15815

wants to merge 1 commit into from

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Oct 3, 2025

Fixes #14998

changelog: [zero_repeat_side_effects]: don't suggest unsuggestable types

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 3, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a
Copy link
Contributor Author

ada4a commented Oct 3, 2025

Depends on #15814, so @rustbot blocked

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 3, 2025
@ada4a ada4a force-pushed the zero_repeat_side_effects-2 branch from c6d3ae9 to e7f9acf Compare October 3, 2025 23:24
@rustbot

This comment has been minimized.

Sign in to view
@ada4a ada4a force-pushed the zero_repeat_side_effects-2 branch from e7f9acf to 434fe18 Compare October 4, 2025 13:57
@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ada4a
Copy link
Contributor Author

ada4a commented Oct 4, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zero_repeat_side_effects would require never_type which is not stable yet
3 participants
@ada4a @rustbot @Jarcho